Env REQUEST_URI can contain query params.

[adambro]

This is a typical scenario on tests, where REQUEST_URI contains path and
all params to perform a request. No need to set QUERY_STRING in
environment separately.

[coveralls]

Coverage increased (+0.006%) to 96.609% when pulling ab5fa78 on adambro:request_uri_with_params into 30cfe3c on slimphp:3.x.

[akrabat]

Which tests don't set up the Request object correctly?

[adambro]

I've meant my own test cases where I use the mock factory to create
request. It is not about tests from framework itself.

Anyway REQUEST_URI can contain query string parameters so would be nice to
account for it.

On 26 Jul 2016 11:16, "Rob Allen" [email protected] wrote:

Which tests don't set up the Request object correctly?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1896 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAnoES8eVt-N5mndIYiehqQXy1fhq0Rjks5qZdBZgaJpZM4IobbU
.