Fix warning when failing to resolve callables of [$class,$method] format #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to properly parse callables in [$class,$method] format.
|
|
Can you provide a unit test for this. Also there's a build failure. |
akrabat
added a commit
that referenced
this pull request
Jul 26, 2016
akrabat
changed the title
|
Oh, sorry for no unit testings, i just saw you answered me here:( |
|
No worries :) Thanks for fixing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When i used Slim3 with callables '\App\Controller\Main','mainMethod' when there weren't class loaded, instead of proper error i was getting conversion array to string errors from previous line. This patch fixes the issue by json_encoding the callable before trying to sprintf %s it.