Ensure withJson returns a new Response #1975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue 1818. The withJson method now clones the Response, and updates this with a new header, and a new Body.
Slim/Http/Response.php
Outdated
| $body->rewind(); | ||
| $body->write($json = json_encode($data, $encodingOptions)); | ||
| $clone = clone $this; | ||
| $clone->body = new Body(fopen('php://temp', 'w+')); |
There was a problem hiding this comment.
I think it's better to use $newResponse = $this->withBody(new Body(fopen('php://temp', 'r+'))) instead of clone and set.
There was a problem hiding this comment.
Where does newResponse come from?
I like clone as it's quick.
There was a problem hiding this comment.
I was just saying to use withBody, cause if we have a method for return a new response with a new body, we don't need to reimplement it.
There was a problem hiding this comment.
I think @mathmarques makes a good point. withBody clones and sets the body, so it's the same code really. It may make more sense to do this instead of duplicating code.
Changed withJson to use withBody to create a new Response instead of cloning and setting a new body directly.
|
Merging #1978 will fix the php7 failing tests. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1818. The withJson method now clones the Response, and
updates this with a new header, and a new Body.