Extra tests #1979
Closed
Extra tests #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This requires #1978 to be merged to fix the php7 build issues. |
akrabat
reviewed
Oct 11, 2016
| $uri = Uri::createFromString('https://example.com:443/foo/bar?abc=123'); | ||
| $headers = new Headers([ | ||
| 'Content-Type' => 'application/x-www-form-urlencoded', | ||
| 'Content-Type' => 'application/json', |
Member
There was a problem hiding this comment.
Why did you change this? Practically, _METHOD overrides are only going to be used with HTML forms.
Contributor
Author
There was a problem hiding this comment.
I was testing decoding of objects, but I can't remember the reasons now.
I think it's safe for you to ignore this, and for me to learn to write better commit messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extra tests to increase code coverage.