Skip to content

Conversation

@sander-bol
Copy link
Contributor

Makes getMethod() internally use getParsedBodyParam() for determining the value of _METHOD in the request body, for purposes of overriding the body.

Question though: wouldn't this type of method-juggling be more appropriately implemented as a middleware rather than living in the core Request object logic, so it becomes an opt-in behaviour?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 97.256% when pulling 2742aa0 on sbol-coolblue:improvement/parsedBodyParam into 2f29cc2 on slimphp:3.x.

@akrabat
Copy link
Member

akrabat commented Nov 14, 2016

Yes. _METHOD will certainly be moved to middleware for 4.0

@akrabat akrabat added this to the 3.6.0 milestone Nov 14, 2016
@akrabat akrabat merged commit 2742aa0 into slimphp:3.x Nov 18, 2016
@akrabat
Copy link
Member

akrabat commented Nov 18, 2016

Thanks.

@sander-bol
Copy link
Contributor Author

You're welcome, and thanks for accepting my little contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants