Fixed failing test by correcting translated Spanish result. #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es what Google Translate API is providing for the given input.
|
Thanks! Yes, it looks like the API was updated such that the translation was changed. |
sloria
added a commit
that referenced
this pull request
Feb 11, 2016
Fixed failing test by correcting translated Spanish result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear to me how this test case ever worked; perhaps the API was translating this string differently in the past. In any case, the Google Translate API today translates "This is a sentence." into Spanish as "Esta es una oración.", and this PR updates the test to match.