Skip to content

Fix NPE in SoftButtonReplaceOperation #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix NPE in SoftButtonReplaceOperation #1772

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bed623d
Add check for NPE in SoftButtonReplaceOperation
Dec 1, 2021
5f04475
Update return statement to be high speed
Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update return statement to be high speed
  • Loading branch information
Julian Kast committed Dec 2, 2021
commit 5f04475937e930432be29ebfe3c3d9e0f8260ff9
2 changes: 1 addition & 1 deletion base/src/main/java/com/smartdevicelink/managers/screen/SoftButtonReplaceOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ private boolean allCurrentStateImagesAreUploaded() {
}

private boolean supportsSoftButtonImages() {
return softButtonCapabilities != null ? Boolean.TRUE.equals(softButtonCapabilities.getImageSupported()) : false;
return softButtonCapabilities != null && Boolean.TRUE.equals(softButtonCapabilities.getImageSupported());
}

void setCurrentMainField1(String currentMainField1) {
Expand Down