Skip to content

Hotfix/5.3.1 #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 8, 2021
Merged

Hotfix/5.3.1 #1773

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d28384
Add check for NPE in SoftButtonReplaceOperation
Dec 1, 2021
ecd265f
Update return statement to be high speed
Dec 2, 2021
f818b87
Move keyboard listener to start of operation
Nov 30, 2021
8fe43f1
Move adding a keyboard listener to only if its a present operation an…
Nov 30, 2021
331e8f9
fix typo
Nov 30, 2021
f1b9046
Update Changelog
RHenigan Dec 6, 2021
286325b
Update Version Number
RHenigan Dec 6, 2021
7c8995b
BuildConfig Change
RHenigan Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move keyboard listener to start of operation
  • Loading branch information
@RHenigan
Julian Kast authored and RHenigan committed Dec 6, 2021
commit f818b87df76916042a80b7e0041e2e47964ffbf3
2 changes: 1 addition & 1 deletion ...in/java/com/smartdevicelink/managers/screen/choiceset/PreloadPresentChoicesOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ public void onExecute() {
choiceId = 1;
reachedMaxIds = false;
}
addListeners();

DebugTool.logInfo(TAG, "Choice Operation: Executing preload choices operation");
// Enforce unique cells and remove cells that are already loaded
Expand Down Expand Up @@ -343,7 +344,6 @@ private void updateKeyboardProperties(final CompletionListener listener) {
return;
}

addListeners();

if (keyboardListener != null && choiceSet.getCustomKeyboardConfiguration() != null) {
keyboardProperties = choiceSet.getCustomKeyboardConfiguration();
Expand Down