Skip to content

Conversation

@joeygrover
Copy link
Member

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against TDK and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Core Tests

  • Deploy app to phone
  • Connect USB
  • Disconnect USB
  • Reconnect USB
  • Perform d/c and reconnect multiple times. Before PR the notification would sometimes stay in the tray.

Summary

  • Fixed incorrect params being sent to notification methods from Android
  • Fixed calling exitForeground during all closing calls.
  • Fixed alt transport timer used for USB transfer to close down/stop on USB disconnection

Changelog

Bug Fixes
  • Notification issues with RS during USB transport

CLA

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1797 (28eeac1) into 5.4.0_RC (7094f6f) will decrease coverage by 0.41%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             5.4.0_RC    #1797      +/-   ##
==============================================
- Coverage       54.09%   53.68%   -0.42%     
- Complexity       5519     5532      +13     
==============================================
  Files             562      562              
  Lines           25714    26110     +396     
  Branches         3372     3499     +127     
==============================================
+ Hits            13909    14016     +107     
- Misses          10545    10827     +282     
- Partials         1260     1267       +7     
Impacted Files Coverage Δ
...om/smartdevicelink/transport/SdlRouterService.java 10.68% <0.00%> (-0.03%) ⬇️
.../managers/screen/menu/BaseVoiceCommandManager.java 82.11% <0.00%> (-1.09%) ⬇️
...com/smartdevicelink/util/MediaStreamingStatus.java 63.80% <0.00%> (-0.96%) ⬇️
...elink/managers/lifecycle/BaseLifecycleManager.java 17.06% <0.00%> (+3.29%) ⬆️
...nk/managers/audio/AudioDecoderCompatOperation.java 79.54% <0.00%> (+4.54%) ⬆️

@JulianKast JulianKast merged commit a624a06 into 5.4.0_RC Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants