Skip to content

Make managers aware of artwork overwrite property #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2020
Merged

Make managers aware of artwork overwrite property #368

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddca25e
Make managers aware of artwork overwrite property
crokita Dec 15, 2020
5bfa293
Apply suggestions from code review
crokita Dec 16, 2020
cf0eed9
Update lib/js/src/manager/screen/_SoftButtonManagerBase.js
crokita Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: renonick87 <[email protected]>
  • Loading branch information
@crokita @renonick87
crokita and renonick87 authored Dec 16, 2020
commit 5bfa29302a7df6ccb8400b886e4566899c59c167
4 changes: 2 additions & 2 deletions lib/js/src/manager/file/_FileManagerBase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ class _FileManagerBase extends _SubManagerBase {
* 1) the file has the overwrite property set to true
* 2) the file hasn't been uploaded to Core before.
*
* @param {SdlFile} sdlFile - SdlFile with file name and one of A) fileData, B) Uri, or C) resourceID set
* @param {SdlFile} file - SdlFile with file name and one of A) fileData, B) Uri, or C) resourceID set
* @returns {Boolean} - Whether file has been uploaded to core (true) or not (false)
*/
fileNeedsUpload (file = null) {
Expand All @@ -253,4 +253,4 @@ class _FileManagerBase extends _SubManagerBase {

const SPACE_AVAILABLE_MAX_VALUE = _FileManagerBase.SPACE_AVAILABLE_MAX_VALUE = 2000000000;

export { _FileManagerBase };
export { _FileManagerBase };
2 changes: 1 addition & 1 deletion lib/js/src/manager/file/filetypes/SdlFile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ class SdlFile {

/**
* Sets the overwrite property for an SdlFile
* @param {Boolean} fileName - A boolean value that indicates if the file can be overwritten
* @param {Boolean} overwrite - A boolean value that indicates if the file can be overwritten
* @returns {SdlFile} - A reference to this instance to support method chaining
*/
setOverwrite (overwrite) {
Expand Down