Skip to content

Fix SdlProtocolBase setting wrong protocol version #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

Fix SdlProtocolBase setting wrong protocol version #388

merged 2 commits into from
Mar 2, 2021

Conversation

@renonick87
Copy link
Contributor

@renonick87 renonick87 commented Feb 24, 2021 •
edited
Loading

Fixes #387

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
Bug Fixes
  • The SdlProtocolBase will no longer attempt to incorrectly set the protocol version to v5.1 when the major version of the first packet header is > 5.

CLA

@renonick87 renonick87 merged commit 1e9ca69 into develop Mar 2, 2021
@crokita crokita deleted the bugfix/wrong-protocol-version branch March 26, 2021 13:56
@crokita crokita mentioned this pull request Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crokita crokita crokita approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_SdlProtocolBase sets the wrong protocol version on the first packet received

3 participants

@renonick87 @crokita