Skip to content

Update Example apps for 1.3 #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Update Example apps for 1.3 #402

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29f5ac3
Update Example apps for 1.3
renonick87 Mar 22, 2021
4c30aa3
Fix logic for when multiple HMI_FULL notifications are sent after eac…
renonick87 Mar 22, 2021
7881a6b
Fix example code block not being wrapped in promise
renonick87 Mar 22, 2021
2ea3fbe
Remove unnecessary log
renonick87 Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix logic for when multiple HMI_FULL notifications are sent after eac… 
…h other as a result of ChoiceSets/Alerts
  • Loading branch information
@renonick87
renonick87 committed Mar 22, 2021
commit 4c30aa3fbd551ff5106996a997957507ecff64c0
5 changes: 3 additions & 2 deletions examples/js/hello-sdl/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@
this._logPermissions();

// wait for the FULL state for more functionality
if (hmiLevel === SDL.rpc.enums.HMILevel.HMI_FULL && this._prevHmiLevel !== SDL.rpc.enums.HMILevel.HMI_FULL) {
const prevHmiFull = this._prevHmiLevel !== SDL.rpc.enums.HMILevel.HMI_FULL
this._prevHmiLevel = hmiLevel;
if (hmiLevel === SDL.rpc.enums.HMILevel.HMI_FULL && prevHmiFull) {
const screenManager = this._sdlManager.getScreenManager();
const isRpcAllowed = (rpc) => {
if (!this._permissionManager) {
Expand Down Expand Up @@ -255,7 +257,6 @@

screenManager.presentAlert(alertView, alertCompletionListener);
}
this._prevHmiLevel = hmiLevel;
}

async _sleep (timeout = 1000) {
Expand Down
5 changes: 3 additions & 2 deletions examples/node/hello-sdl-tcp/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ class AppClient {
this._logPermissions();

// wait for the FULL state for more functionality
if (hmiLevel === SDL.rpc.enums.HMILevel.HMI_FULL && this._prevHmiLevel !== SDL.rpc.enums.HMILevel.HMI_FULL) {
const prevHmiFull = this._prevHmiLevel !== SDL.rpc.enums.HMILevel.HMI_FULL;
this._prevHmiLevel = hmiLevel;
if (hmiLevel === SDL.rpc.enums.HMILevel.HMI_FULL && prevHmiFull) {
const screenManager = this._sdlManager.getScreenManager();
const isRpcAllowed = (rpc) => {
if (!this._permissionManager) {
Expand Down Expand Up @@ -252,7 +254,6 @@ class AppClient {

screenManager.presentAlert(alertView, alertCompletionListener);
}
this._prevHmiLevel = hmiLevel;
}

_onButtonListener (buttonName, onButton) {
Expand Down
5 changes: 3 additions & 2 deletions examples/node/hello-sdl/AppClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,12 @@ class AppClient {
this._logPermissions();

// wait for the FULL state for more functionality
if (hmiLevel === SDL.rpc.enums.HMILevel.HMI_FULL && this._prevHmiLevel !== SDL.rpc.enums.HMILevel.HMI_FULL) {
const prevHmiFull = this._prevHmiLevel !== SDL.rpc.enums.HMILevel.HMI_FULL;
this._prevHmiLevel = hmiLevel;
if (hmiLevel === SDL.rpc.enums.HMILevel.HMI_FULL && prevHmiFull) {
this._hmiFull = true;
this._checkReadyState();
}
this._prevHmiLevel = hmiLevel;
}

async _checkReadyState () {
Expand Down