Skip to content

Merge master into develop #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Oct 27, 2021
Merged

Merge master into develop #513

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
93014b1
Fix boolean return
crokita Oct 18, 2021
1e6c2c0
Make detaching listener happen all the time in finishOperation
crokita Oct 18, 2021
8b692df
Fix MenuReplaceOperations being added and run synchronously
renonick87 Oct 19, 2021
fbb3f8f
Fix MenuReplaceOperation onExecute not being async, and update method…
renonick87 Oct 20, 2021
973a448
Fix return values of _setMenuCells
renonick87 Oct 20, 2021
26eb4be
Move fix to below LCM null check
crokita Oct 20, 2021
1f17de4
Merge pull request #496 from smartdevicelink/bugfix/preload-artworks-…
crokita Oct 20, 2021
65e2bf8
Initialize button ID sets on connection
renonick87 Oct 20, 2021
9cff773
Fix some tasks having an onExecute method that is not async
renonick87 Oct 21, 2021
8d578cf
Merge pull request #498 from smartdevicelink/bugfix/keyboard-listener…
crokita Oct 21, 2021
fb08253
Merge pull request #502 from smartdevicelink/bugfix/initialize-button…
renonick87 Oct 22, 2021
4dfe8a9
Merge pull request #500 from smartdevicelink/bugfix/menu-replace-runn…
renonick87 Oct 22, 2021
98c1eb4
Update build dependencies to remove vulnerabilities
renonick87 Oct 22, 2021
85bdb97
Revert package update that would have required higher node/npm version
renonick87 Oct 22, 2021
0b18a02
Log warning when trying to set voice commands for a SubMenu cell
renonick87 Oct 25, 2021
0ea3941
Merge pull request #503 from smartdevicelink/bugfix/vulnerabilities-1…
renonick87 Oct 25, 2021
60be7ac
Handle case where voice commands are set to an empty array
renonick87 Oct 25, 2021
c641afd
Fix alert view cancel listener not being set when presenting
renonick87 Oct 26, 2021
9173b0a
Merge pull request #505 from smartdevicelink/bugfix/submenu-voice-com…
renonick87 Oct 26, 2021
3eaf029
Fix alert CancelInteraction to use setters and add return statements …
renonick87 Oct 26, 2021
ec0e4df
Fix console log
renonick87 Oct 26, 2021
27ca179
Merge pull request #510 from smartdevicelink/bugfix/alert-view-cancel…
renonick87 Oct 26, 2021
57bed19
Update rpc spec
crokita Oct 27, 2021
c34b900
Merge pull request #511 from smartdevicelink/feature/update-spec-8.0
crokita Oct 27, 2021
f371912
Merge pull request #512 from smartdevicelink/release/1.5.0_RC
crokita Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix boolean return
  • Loading branch information
@crokita
crokita committed Oct 18, 2021
commit 93014b14d43b5414ba4f9a7e3ca44205f5931253
2 changes: 1 addition & 1 deletion lib/js/src/manager/screen/choiceset/_PreloadPresentChoicesOperation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ class _PreloadPresentChoicesOperation extends _Task {
console.error('PreloadChoicesOperation: Error uploading choice cell artworks');
}

return uploadResults.includes(false);
return !uploadResults.includes(false);
}

/**
Expand Down