Skip to content

Conversation

@smjonas
Copy link
Owner

@smjonas smjonas commented Sep 24, 2022

Supersedes #8. The reason I closed the previous PR is because there were too many problems with it and progress was very slow. For 1.0, I want to start with a minimal but robust plugin based on vim.diff instead of the current custom diff algorithm. T

Breaking changes in v1.0

  • Changed the module name to inc-rename to match the repo name.
  • Removed the hl_range option. This is now handled automatically (the diff is computed for the whole buffer but only diffs for the visible lines are displayed).

New features

  • Added interline_highlighting option (default true). If true, the diff will be computed within a line, i.e. a line may consist of multiple highlights. Otherwise there will be a single change highlight for the whole line.
  • Allow command.args to be a function that takes in the original arguments passed to the command and returns the transformed arguments.
  • Added command.range to override the default range / count.
  • Logging: new :LiveCommandLog command and debug option

@smjonas smjonas marked this pull request as draft September 24, 2022 15:13
@smjonas smjonas force-pushed the 1.0_release branch 2 times, most recently from 8a487a7 to 8698945 Compare September 27, 2022 07:04
@smjonas
Copy link
Owner Author

smjonas commented Oct 4, 2022

Hey @AckslD, would you be interested in test-driving this branch for a while? Finally had enough motivation and time to get this plugin into a reasonably stable state (after wasting a bit too much time on essentially trying to create a custom diff algorithm 😄).

Now, I'm simply using vim.diff (for linewise and diffs across lines). I also removed the hl_range option as this will now be taken care of by the plugin itself.

Let me know what you think and whether you notice any issues!

@smjonas smjonas force-pushed the 1.0_release branch 10 times, most recently from 6b2a4c9 to d8968e1 Compare October 6, 2022 11:23
@smjonas smjonas marked this pull request as ready for review October 6, 2022 13:17
@smjonas smjonas merged commit e7d0f1b into main Oct 6, 2022
@smjonas smjonas deleted the 1.0_release branch October 6, 2022 13:20
@AckslD
Copy link

AckslD commented Oct 10, 2022

Hi @smjonas, sorry for a late reply but I was travelling and was offline. Cool to see that 1.0 is released 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants