Skip to content

Remove unnecessary std::thread_local! #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unnecessary std::thread_local! #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions src/runnable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,15 +437,6 @@ impl<M> Builder<M> {
use std::task::{Context, Poll};
use std::thread::{self, ThreadId};

#[inline]
fn thread_id() -> ThreadId {
std::thread_local! {
static ID: ThreadId = thread::current().id();
}
ID.try_with(|id| *id)
.unwrap_or_else(|_| thread::current().id())
}

struct Checked<F> {
id: ThreadId,
inner: ManuallyDrop<F>,
Expand All @@ -454,7 +445,7 @@ impl<M> Builder<M> {
impl<F> Drop for Checked<F> {
fn drop(&mut self) {
assert!(
self.id == thread_id(),
self.id == thread::current().id(),
"local task dropped by a thread that didn't spawn it"
);
unsafe {
Expand All @@ -468,7 +459,7 @@ impl<M> Builder<M> {

fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
assert!(
self.id == thread_id(),
self.id == thread::current().id(),
"local task polled by a thread that didn't spawn it"
);
unsafe { self.map_unchecked_mut(|c| &mut *c.inner).poll(cx) }
Expand All @@ -480,7 +471,7 @@ impl<M> Builder<M> {
let future = future(meta);

Checked {
id: thread_id(),
id: thread::current().id(),
inner: ManuallyDrop::new(future),
}
};
Expand Down