Skip to content

Ws drain fix #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rauchg merged 18 commits into from
Mar 17, 2013
Merged

Ws drain fix #140

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e358f0d
add 'drain' emit to WS
albertyfwu Mar 16, 2013
bf13803
make sure to stop interval if transport closes
albertyfwu Mar 16, 2013
8ea4bb9
feature-check for bufferedAmount
albertyfwu Mar 16, 2013
28766db
fix featurecheck
albertyfwu Mar 16, 2013
c16137a
added fake drain
albertyfwu Mar 17, 2013
d5fa387
wrapped drain call, changed back to encodePacket, moved intervalClean…
albertyfwu Mar 17, 2013
dab01cf
removed irrelevant code
albertyfwu Mar 17, 2013
05a0647
add 'drain' emit to WS
albertyfwu Mar 16, 2013
7d941af
make sure to stop interval if transport closes
albertyfwu Mar 16, 2013
e652ead
feature-check for bufferedAmount
albertyfwu Mar 16, 2013
0874020
fix featurecheck
albertyfwu Mar 16, 2013
aa5dec5
added fake drain
albertyfwu Mar 17, 2013
74094e1
wrapped drain call, changed back to encodePacket, moved intervalClean…
albertyfwu Mar 17, 2013
71ed033
removed irrelevant code
albertyfwu Mar 17, 2013
d6ba4f8
Merge branch 'ws_drain_fix' of https://github.com/albertyfwu/engine.i…
albertyfwu Mar 17, 2013
f3710ff
fixed websocket flush/drain loop
albertyfwu Mar 17, 2013
1f6ee88
changes
albertyfwu Mar 17, 2013
fdb95d5
changes
albertyfwu Mar 17, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed irrelevant code
  • Loading branch information
@albertyfwu
albertyfwu committed Mar 17, 2013
commit 71ed0336986481f9a91daf686c06f547508a5930
5 changes: 2 additions & 3 deletions lib/transport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ Transport.prototype.close = function () {
* @api private
*/

Transport.prototype.send = function(packets, fn){
Transport.prototype.send = function(packets){
if ('open' == this.readyState) {
this.write(packets, fn);
this.write(packets);
} else {
throw new Error('Transport not open');
}
Expand Down Expand Up @@ -137,6 +137,5 @@ Transport.prototype.onPacket = function (packet) {

Transport.prototype.onClose = function () {
this.readyState = 'closed';
this.intervalCleanup && this.intervalCleanup.call(this);
this.emit('close');
};