Skip to content

add test demonstrating #595 in firefox #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darrachequesne merged 5 commits into from
Mar 9, 2018
Merged

add test demonstrating #595 in firefox #596

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
751a732
add test demonstrating the issue in firefox; this fails for me about …
devoidfury Mar 6, 2018
4cf841f
add test for binary data in worker
devoidfury Mar 7, 2018
2ff3a54
fix #595 by delaying setting xhr.responseType=arraybuffer until xhr r…
devoidfury Mar 7, 2018
a3125aa
fix style
darrachequesne Mar 8, 2018
84d1da0
remove useless case
darrachequesne Mar 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix #595 by delaying setting xhr.responseType=arraybuffer until xhr r… 
…ecieved headers state
  • Loading branch information
@devoidfury
devoidfury committed Mar 7, 2018
commit 2ff3a5431ae7b6dffa72bde26cd984707c48d635
7 changes: 2 additions & 5 deletions lib/transports/polling-xhr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,6 @@ Request.prototype.create = function () {
xhr.setRequestHeader('Accept', '*/*');
} catch (e) {}

if (this.supportsBinary) {
xhr.responseType = 'arraybuffer';
}

// ie6 check
if ('withCredentials' in xhr) {
Expand All @@ -245,8 +242,8 @@ Request.prototype.create = function () {
if (xhr.readyState === 2) {
try {
var contentType = xhr.getResponseHeader('Content-Type');
if (contentType !== 'application/octet-stream') {
xhr.responseType = 'text';
if (self.supportsBinary && contentType === 'application/octet-stream') {
xhr.responseType = 'arraybuffer';
}
} catch (e) {}
}
Expand Down