Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.4.1
Choose a base ref
...
head repository: socketio/engine.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.4.2
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jun 4, 2020

  1. fix: remove explicit require of uws 

    So that bundlers like webpack do not try to include it in the build.

As a side-effect, any implementation which matches the API of the ws
module can now be used.

Before that change, you had to explicitly exclude uws:

```
// webpack.config.js
module.exports = {
  // ...
  externals: {
     uws: 'uws'
  }
};
```

Related: #575

Backported from master: 82cdca2
    @darrachequesne
    darrachequesne committed Jun 4, 2020
    1 Configuration menu
    Copy the full SHA
    85e544a View commit details
    Browse the repository at this point in the history

  2. chore: release 3.4.2 

    Diff: 3.4.1...3.4.2
    @darrachequesne
    darrachequesne committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    b68ed6f View commit details
    Browse the repository at this point in the history
Loading