Skip to content

fixed: custom parser is broken #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuhj86 wants to merge 1 commit into from
Closed

fixed: custom parser is broken #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ export class Adapter extends EventEmitter {

packet.nsp = this.nsp.name;
const encodedPackets = this.encoder.encode(packet);

const isString = typeof encodedPackets[0] == "string";
Copy link

@Benedicht Benedicht May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a javascript guru, but seeing the typeof examples shouldn't it be const isString = typeof encodedPackets[0] === "string"; ?

const firstPacketOpts = {
wsPreEncoded: "4" + encodedPackets[0], // "4" being the "message" packet type in Engine.IO
wsPreEncoded: isString ? "4" + encodedPackets[0] : encodedPackets[0], // "4" being the "message" packet type in Engine.IO
...packetOpts
};

Expand Down