Subscribes before calling onopen (1.0) #539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgress454
added a commit
to sgress454/socket.io-client
that referenced
this pull request
Feb 16, 2017
Includes the following (from engine.io-client changelog): * [chore] Bump ws to version 1.1.2 (vulnerability fix) ([socketio#539](socketio/engine.io-client#539)) * [fix] Fix extraHeaders option in browser ([socketio#536](socketio/engine.io-client#536))
darrachequesne
pushed a commit
that referenced
this pull request
Feb 16, 2017
Includes the following (from engine.io-client changelog): * [chore] Bump ws to version 1.1.2 (vulnerability fix) ([#539](socketio/engine.io-client#539)) * [fix] Fix extraHeaders option in browser ([#536](socketio/engine.io-client#536))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors happen when you open another new connection with a namespace after establishing the connection.
Uncaught TypeError: Cannot call method 'push' of undefined
Uncaught TypeError: Cannot read property 'length' of undefined