No more 'Invalid namespace' since 2.1.1 compared to 2.1.0

[sp00m]

In 2.1.0, when a client tries to connect with an invalid namespace, an error was emitted: Invalid namespace.

In 2.1.1, this error isn't emitted anymore.

The only proper code diff between 2.1.0 and 2.1.1 seems to be local added to flags. Any idea how could this simple change have such an impact?

[sp00m]

Might not be due to Socket.IO 2.1.1 version finally, closing this ticket for now, will possibly reopen it later on after a better investigation.

[sp00m]

Double checked and confirmed: error emitted with 2.1.0, not emitted with 2.1.1. Detected with bow. Replicate:

1. Checkout bow, branch develop;
2. run npm install and npm test: test OutboundServer should fail when specifying a namespace should be successful (some other tests may fail if you don't have a Redis server running locally);
3. update socket.io and socket.io-client dependencies from 2.1.0 to 2.1.1 in package.json;
4. rerun npm install and npm test: the above test now fails as no Invalid namespace error is emitted anymore.

Socket.IO server is created in lib/OutboundServer.js.

[darrachequesne]

@sp00m thanks for providing a way to reproduce, that really helps debugging the issue 👍

I think it is related to the following fix: socketio/socket.io-client#1202

The checkVersion method in your code there throws an exception "Version not found in handshake request, expected query parameter" in the failing test.

Before the fix, the error message was ignored on the client-side, and the error event was emitted once you try to connect to the namespace /foo/bar.

Now, the first error message ("Version not found in...") is not ignored anymore, and the error event is emitted twice.

[sp00m]

Thanks @darrachequesne! Indeed, I just tried giving a valid version to the previously failing test, and it's now passing successfully (i.e. fails with Invalid namespace as expected).

Looks like in 2.1.0, the namespace validity was checked before my checkVersion middleware, while in 2.1.1, my checkVersion middleware is checked before the namespace validity.

Anyway, as long as Invalid namespace is still thrown, I'm happy :)

Thanks for investigating, should have done this check earlier by myself.

Keep up the great job!