Skip to content

Misc #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rauchg merged 2 commits into from
May 9, 2011
Merged

Misc #202

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a5ab76
Updated the package.json, added more keywords. Added repo and fixed t…
3rd-Eden May 7, 2011
8f1d96a
Updated the readme, fixed typos, changed `socket.io` requires to `soc…
3rd-Eden May 7, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updated the package.json, added more keywords. Added repo and fixed t… 
…he engine requirement or it will not work with future node versions.
  • Loading branch information
@3rd-Eden
3rd-Eden committed May 7, 2011
commit 3a5ab7675d17b3b1497b30938ae85e89473d737a
8 changes: 6 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,17 @@
"name": "socket.io-node"
, "version": "0.7.0"
, "description": "Realtime apps made cross-browser & easy with a WebSocket-like API"
, "keywords": ["websocket", "socket", "realtime"]
, "keywords": ["websocket", "socket", "realtime", "socket.io", "comet", "ajax"]
, "author": "Guillermo Rauch <[email protected]>"
, "contributors": [
{ "name": "Guillermo Rauch", "email": "[email protected]" }
, { "name": "Arnout Kazemier", "email": "[email protected]" }
]
, "repository":{
"type": "git"
, "url": "https://github.com/LearnBoost/Socket.IO-node.git"
}
, "dependencies": {}
, "main": "index"
, "engines": { "node": "0.4.x" }
, "engines": { "node": ">= 0.4.0" }
Copy link
Contributor

@tj tj May 7, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't do that, this bit me with many of my earlier modules

Copy link
Contributor Author

@3rd-Eden 3rd-Eden May 8, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both situations are indeed less than ideal, but the previous version was to restrictive this allows 0.4 and >. So I guess there isn't perfect solution for this.

Copy link
Contributor

@tj tj May 8, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were you wanting to use it with the 0.5.x stuff? maybe >= 0.4.0 < 0.6.0 would be ok

Copy link
Contributor Author

@3rd-Eden 3rd-Eden May 8, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I develop and test all code on 0.4 and 0.5 to ensure a flawless upgrade once a new stable node.js is available.
So I guess a >= 0.4.0 < 0.6.0 would be suitable for this.

Want me to update the commit?
On May 8, 2011, at 7:13 PM, visionmedia wrote:

, "dependencies": {}
, "main": "index"

  • , "engines": { "node": "0.4.x" }
  • , "engines": { "node": ">= 0.4.0" }

were you wanting to use it with the 0.5.x stuff? maybe >= 0.4.0 < 0.6.0 would be ok

Reply to this email directly or view it on GitHub:
https://github.com/LearnBoost/Socket.IO-node/pull/202/files#r27205

Copy link
Contributor

@tj tj May 8, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally I dont think people should be targeting 0.5.x at all, it's just not really a concern right now but we'll see what @guille thinks. IMO we should leave it at 0.4.x

}