Skip to content

Throws an error when trying to access the clients of a dynamic namespace #3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darrachequesne merged 1 commit into from
Nov 20, 2018
Merged

Throws an error when trying to access the clients of a dynamic namespace #3355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Throws an error when trying to access the clients of a dynamic namespace
  • Loading branch information
@0xClpz
0xClpz committed Oct 23, 2018
commit db4596a8383eee7e167d7d9cc41dabdb9683118c
3 changes: 3 additions & 0 deletions lib/namespace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,9 @@ Namespace.prototype.write = function(){
*/

Namespace.prototype.clients = function(fn){
if(!this.adapter){
throw new Error('No adapter for this namespace, are you trying to get the list of clients of a dynamic namespace?')
}
this.adapter.clients(this.rooms, fn);
// reset rooms for scenario:
// .in('room').clients() (GH-1978)
Expand Down