-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Update most dependencies #3711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update most dependencies #3711
Conversation
|
the debug upgrade also fixes a deprecation warning upon a fresh installation of |
|
Hi guys, can you let me know what is stopping this PR from getting merged? If there is an issue I will be happy to try and address your concerns. @darrachequesne Pinging you because you seem the most active committer... |
|
Great work @Download! It seems like their are conflicts unfortunately. |
|
@divlo Yeah. There weren't any when I submitted this PR, but of course if it is not merged then eventually conflicts will happen... |
|
Merged as 230cd19. Thanks! The tests indeed fails when upgrading mocha, because the client/server objects are not properly closed in some tests... I'll see what I can do. Note: for prod dependencies, I prefer using |
|
How about enabling Dependabot or Renovate to make sure socket.io receives further updates? |
That makes sense, let's do this! |
|
Awesome. Well, since Dependabot is built into GitHub theses days, all that needs to be done is to add a configuration file in I could open a PR, but I'm not sure which configuration you guys prefer. Same thing could be done for the other repositories in this organization (engine.io, etc). |
The kind of change this PR does introduce
a new featurean update to the documentationa code change that improves performanceotherCurrent behavior
Dependencies are outdated, see #3709
New behavior
All dependencies are updated, except for Mocha and Prettier.
Other information (e.g. related issues)
In order for me to work on this project I first had to fix
Cannot run tests on Windows #3707.I sent a pull request for that:
Make tests work on Windows #3708This PR depends on that PR, so I suggest merging that one first. It's a very small change.
UPDATE: That PR was merged 👍
Then, once that is merged, I suggest merging this PR, which is also a small change.
After that, we can try updating Mocha and Prettier in separate PRs. I left them out because updating them caused some issues: