Fixes issue 523, and (unreported?) issue where flashsocket identifies as websocket #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager.js, wasn't present in hybi parser
…the websocket version being loaded
Contributor
|
It was reported, I marked it under websocket or flashsocket yesterday ;p |
rauchg
added a commit
that referenced
this pull request
Sep 20, 2011
Fixes issue 523, and (unreported?) issue where flashsocket identifies as websocket
darrachequesne
added a commit
that referenced
this pull request
Jul 8, 2024
darrachequesne
added a commit
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a couple of tests to ensure that flashsockets and websockets will continue to identify correctly in the future.
Regarding issue #523, the 'payload' method's comment is semi-misleadingly labeled 'private' -- while it's actually called from manager.js.