fix: Throw error when accessing matrix elements directly

[aleksanderkatan]

No description provided.

[github-actions]

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@981da9e8a8f9d3805e0721d8beadec6429362ce1

https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/noise@981da9e8a8f9d3805e0721d8beadec6429362ce1

https://pkg.pr.new/software-mansion/TypeGPU/unplugin-typegpu@981da9e8a8f9d3805e0721d8beadec6429362ce1

benchmark
view benchmark

commit
view commit

[Copilot]

Pull Request Overview

This PR implements a fix to throw an error when attempting to access matrix elements directly in TGSL, enforcing the proper access pattern through the 'columns' property.

• Adds error handling to prevent direct matrix indexing (e.g., matrix[4])
• Introduces MatrixColumnsAccess class to properly handle matrix column access
• Updates code generation to support the correct matrix access pattern

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
packages/typegpu/src/data/dataTypes.ts	Adds MatrixColumnsAccess class for proper matrix access handling
packages/typegpu/src/tgsl/wgslGenerator.ts	Implements error throwing for direct matrix access and proper code generation for matrix.columns access
packages/typegpu/tests/tgsl/wgslGenerator.test.ts	Adds comprehensive tests for matrix access error cases and correct usage patterns

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[cieplypolar]

LGTM

[aleksanderkatan]

Now, in indexAccess, the index is resolved first, thus the reordering in this file

[iwoplaza]

Awesome changes! Tiny nitpicks 👏