-
-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Make prepareDispatch withable
#1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the prepareDispatch function to return a PreparedDispatch class instance instead of directly returning a dispatch function. The key enhancement is making prepared dispatches "withable" by adding support for binding different bind groups to the same dispatch pipeline.
- Introduces a new
PreparedDispatchclass that wraps the dispatch functionality and adds awith()method - Updates the return type of
prepareDispatchto returnPreparedDispatch<TArgs>instead ofDispatchForArgs<TArgs> - Modifies all existing usage to call
.dispatch()on the returned object instead of calling the function directly
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/typegpu/src/prepareDispatch.ts |
Core implementation adding PreparedDispatch class and with() method |
apps/typegpu-docs/src/examples/tests/log-test/index.ts |
Updates all prepareDispatch calls to use .dispatch() |
apps/typegpu-docs/src/examples/tests/dispatch/index.ts |
Updates calls and adds new test for bind group functionality |
apps/typegpu-docs/src/examples/rendering/3d-fish/index.ts |
Updates variable naming and dispatch call |
apps/typegpu-docs/src/content/docs/fundamentals/utils.mdx |
Updates documentation to reflect new API |
packages/typegpu/tests/examples/individual/dispatch.test.ts |
Updates test expectations for generated WGSL |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
pkg.pr.new packages benchmark commit |
iwoplaza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🫡
No description provided.