feat: Make prepareDispatch withable#1728
Merged
aleksanderkatan merged 15 commits intomainfrom Sep 26, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the prepareDispatch function to return a PreparedDispatch class instance instead of directly returning a dispatch function. The key enhancement is making prepared dispatches "withable" by adding support for binding different bind groups to the same dispatch pipeline.
- Introduces a new
PreparedDispatchclass that wraps the dispatch functionality and adds awith()method - Updates the return type of
prepareDispatchto returnPreparedDispatch<TArgs>instead ofDispatchForArgs<TArgs> - Modifies all existing usage to call
.dispatch()on the returned object instead of calling the function directly
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/typegpu/src/prepareDispatch.ts |
Core implementation adding PreparedDispatch class and with() method |
apps/typegpu-docs/src/examples/tests/log-test/index.ts |
Updates all prepareDispatch calls to use .dispatch() |
apps/typegpu-docs/src/examples/tests/dispatch/index.ts |
Updates calls and adds new test for bind group functionality |
apps/typegpu-docs/src/examples/rendering/3d-fish/index.ts |
Updates variable naming and dispatch call |
apps/typegpu-docs/src/content/docs/fundamentals/utils.mdx |
Updates documentation to reflect new API |
packages/typegpu/tests/examples/individual/dispatch.test.ts |
Updates test expectations for generated WGSL |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
pkg.pr.new packages benchmark commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.