Add TS types to the files #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/react-native-gesture-handler into @wolewicki/configure-ts
Co-authored-by: Jakub <[email protected]>
WoLewicki
reviewed
Feb 2, 2021
| export const DrawerLayoutAndroid = createNativeWrapper(RNDrawerLayoutAndroid, { | ||
| disallowInterruption: true, | ||
| }); | ||
| // @ts-ignore -- TODO(TS) to investigate if it's needed |
Member
There was a problem hiding this comment.
We talked about it sometime ago and I think we should at least deprecate usage of this to encourage people to use literal values of "left" and "right".
Member
There was a problem hiding this comment.
Oh, it is web, so I am not sure.
WoLewicki
reviewed
Feb 2, 2021
Member
WoLewicki
left a comment
WoLewicki
left a comment
There was a problem hiding this comment.
Left some comments, looks good overall!
| export const DrawerLayoutAndroid = createNativeWrapper(RNDrawerLayoutAndroid, { | ||
| disallowInterruption: true, | ||
| }); | ||
| // @ts-ignore -- TODO(TS) to investigate if it's needed |
Member
There was a problem hiding this comment.
Oh, it is web, so I am not sure.
Co-authored-by: Jakub <[email protected]>
Merged
jgonet
added a commit
that referenced
this pull request
Feb 8, 2021
## Description This PR combines three others (#1273, #1280, #1291) and rewrites Gesture Handler and examples to TS. We tried to make non-breaking changes but this should be tested. Most types were overhauled, although they should remain compatible with old ones thanks to the type aliases in the `src/handlers/gestureHandlerTypesCompat.ts` file. CI for iOS was disabled due to strange fails. It should be reenabled when we add unit/e2e tests to RNGH. Fixes #1076 - removed Flow from DrawerLayout Fixes #1261 - added TS types Fixes #998 - regenerated example app Fixes #887 - removed prop types ## Changes ### Package packing, configs & source code - Swipeable and DrawerLayout are now resolved by their own `package.json`s - React Native uses source code directly, browser and TS use files from `dist/` - Removed prop types #### Internal - Removed unused babel config in the root dir, adjust Eslint config - Removed unused functions - Changed private names from `_name` to `private name` - Replaced `x && x()` syntax with `x.?()` ### Types - Added types compatibility layer for the new types (`gestureHandlerTypesCompat.ts`) - Added generation of declarations and declarations map when TS is transpiled - Moved types from declaration files to files with implementation - Added types to Android / iOS / shared JS code - Added basic types to the web version ### Example app - Removed unused bits in examples - Regenerated Example app with latest RN - Removed stray files from examples/ - Updated Travis config to include newer Android build tools & iOS scheme name change - Organized Example code structure - Removed Example tests (they weren't testing anything) - Reconfigured web version of examples ## Testing PRs that were merged into `ts-rewrite` branch were tested by using `npm pack` and adding it to the new app. In the case of #1273 & #1280, we additionally checked bundled diff for changes. We diffed master to generated dist/ directory using `diff --color -wryN -W 200 src/ dist/src`with imports removed by `find src -name "*.js" -type f -exec sed -i '' '/import/d' {} \;` Co-authored-by: WoLewicki <[email protected]> Co-authored-by: Jakub <[email protected]>
mrousavy
pushed a commit
to mrousavy/react-native-gesture-handler
that referenced
this pull request
Feb 11, 2021
This PR combines three others (software-mansion#1273, software-mansion#1280, software-mansion#1291) and rewrites Gesture Handler and examples to TS. We tried to make non-breaking changes but this should be tested. Most types were overhauled, although they should remain compatible with old ones thanks to the type aliases in the `src/handlers/gestureHandlerTypesCompat.ts` file. CI for iOS was disabled due to strange fails. It should be reenabled when we add unit/e2e tests to RNGH. Fixes software-mansion#1076 - removed Flow from DrawerLayout Fixes software-mansion#1261 - added TS types Fixes software-mansion#998 - regenerated example app Fixes software-mansion#887 - removed prop types - Swipeable and DrawerLayout are now resolved by their own `package.json`s - React Native uses source code directly, browser and TS use files from `dist/` - Removed prop types - Removed unused babel config in the root dir, adjust Eslint config - Removed unused functions - Changed private names from `_name` to `private name` - Replaced `x && x()` syntax with `x.?()` - Added types compatibility layer for the new types (`gestureHandlerTypesCompat.ts`) - Added generation of declarations and declarations map when TS is transpiled - Moved types from declaration files to files with implementation - Added types to Android / iOS / shared JS code - Added basic types to the web version - Removed unused bits in examples - Regenerated Example app with latest RN - Removed stray files from examples/ - Updated Travis config to include newer Android build tools & iOS scheme name change - Organized Example code structure - Removed Example tests (they weren't testing anything) - Reconfigured web version of examples PRs that were merged into `ts-rewrite` branch were tested by using `npm pack` and adding it to the new app. In the case of software-mansion#1273 & software-mansion#1280, we additionally checked bundled diff for changes. We diffed master to generated dist/ directory using `diff --color -wryN -W 200 src/ dist/src`with imports removed by `find src -name "*.js" -type f -exec sed -i '' '/import/d' {} \;` Co-authored-by: WoLewicki <[email protected]> Co-authored-by: Jakub <[email protected]>
braincore
pushed a commit
to braincore/react-native-gesture-handler
that referenced
this pull request
Mar 4, 2021
## Description This PR combines three others (software-mansion#1273, software-mansion#1280, software-mansion#1291) and rewrites Gesture Handler and examples to TS. We tried to make non-breaking changes but this should be tested. Most types were overhauled, although they should remain compatible with old ones thanks to the type aliases in the `src/handlers/gestureHandlerTypesCompat.ts` file. CI for iOS was disabled due to strange fails. It should be reenabled when we add unit/e2e tests to RNGH. Fixes software-mansion#1076 - removed Flow from DrawerLayout Fixes software-mansion#1261 - added TS types Fixes software-mansion#998 - regenerated example app Fixes software-mansion#887 - removed prop types ## Changes ### Package packing, configs & source code - Swipeable and DrawerLayout are now resolved by their own `package.json`s - React Native uses source code directly, browser and TS use files from `dist/` - Removed prop types #### Internal - Removed unused babel config in the root dir, adjust Eslint config - Removed unused functions - Changed private names from `_name` to `private name` - Replaced `x && x()` syntax with `x.?()` ### Types - Added types compatibility layer for the new types (`gestureHandlerTypesCompat.ts`) - Added generation of declarations and declarations map when TS is transpiled - Moved types from declaration files to files with implementation - Added types to Android / iOS / shared JS code - Added basic types to the web version ### Example app - Removed unused bits in examples - Regenerated Example app with latest RN - Removed stray files from examples/ - Updated Travis config to include newer Android build tools & iOS scheme name change - Organized Example code structure - Removed Example tests (they weren't testing anything) - Reconfigured web version of examples ## Testing PRs that were merged into `ts-rewrite` branch were tested by using `npm pack` and adding it to the new app. In the case of software-mansion#1273 & software-mansion#1280, we additionally checked bundled diff for changes. We diffed master to generated dist/ directory using `diff --color -wryN -W 200 src/ dist/src`with imports removed by `find src -name "*.js" -type f -exec sed -i '' '/import/d' {} \;` Co-authored-by: WoLewicki <[email protected]> Co-authored-by: Jakub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Session 3: Honky Tonk Rewrite
Last part of the TS rewrite process, in this PR we transfer types from declaration files to their implementations and add missing types for other functions and components.
Change lists are probably not exhaustive but we tried to write most of the changes.
Changes
TS
gestureHandlerTypesCompat.ts).Internal
Source code
"browser"target and updated targets for source and types for Swipeable and DrawerLayout componentspackage.jsons."react-native"entry point toindex.ts(this ensures that clients using RN will load source instead of TS transpiled files)."types"to"dist/index.d.ts".Internal
x && x()withx.?()in various places.Misc
Internal
no-use-before-definerule.StateandNativeViewGestureHandlerare now named export internally.GesturestogestureHandlers.lintnpm script.TODO
eslint-ignores,@ts-ignores, and@ts-nochecksMissing types
src/components/GestureComponents.web.tsxsrc/web/DiscreteGestureHandler.tssrc/web/DraggingGestureHandler.tssrc/web/FlingGestureHandler.tssrc/web/GestureHandler.tssrc/web/IndiscreteGestureHandler.tssrc/web/LongPressGestureHandler.tssrc/web/NativeViewGestureHandler.tssrc/web/PanGestureHandler.tssrc/web/PinchGestureHandler.tssrc/web/PressGestureHandler.tssrc/web/RotationGestureHandler.tssrc/web/TapGestureHandler.tsFurther improvements mentioned in review comments
Test plan
This will be tested by manually checking examples.
Future PRs can be checked by comparing bundle output (create two packages from master and this branch using
npm pack, install one and then second later, create two bundles viayarn react-native bundle --entry-file=index.js --bundle-output=rngh.bundle --reset-cache --minify=false, and compare results withdiff rngh.bundle rngh.ts.bundle). This PR is too big (18k diff) so we didn't do that.