Improve wording and add defaults to TapHandler docs #1319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgonet
reviewed
Feb 1, 2021
| ### `maxDelayMs` | ||
|
|
||
| Time expressed in milliseconds which could pass before next tap if many taps are required. Default is 300ms. | ||
| Maximum time, expressed in milliseconds, that can pass before the next tap--if many taps are required. The default value is 500. |
| ### `absoluteY` | ||
|
|
||
| Y coordinate of the current position of the pointer (finger or a leading pointer when there are multiple fingers placed) relative to the root view. The value is expressed in point units. It is recommended to use it instead of [`y`](#y) in cases when the original view can be transformed as an effect of the gesture. | ||
| Y coordinate, expressed in points, of the current position of the pointer (finger or a leading pointer when there are multiple fingers placed) relative to the root view. It is recommended to use this instead of [`y`](#y) in cases when the view attached to the handler can be transformed as an effect of the gesture. |
Member
There was a problem hiding this comment.
I'm not sure about "this". I'd leave the original "it" or change it to the "absoluteY".
Contributor
Author
There was a problem hiding this comment.
I agree, I think "absoluteY" is the best approach
jgonet
changed the title
Contributor
Author
|
hey sorry, moved this to pull#1325 |
Member
|
No worries, we can change merge destination and merge it to this one. |
Member
|
Seems like github isn't picking up the fork, let's close this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed default value mentioning to - "The default value is" in order to match the react natives docs
edited for more consistency in explanations
please review the default values because I'm not entirely sure... the information I got was from the android directory - android/lib/src/main/java/com/swmansion/gesturehandler/TapGestureHandler.java