Skip to content

Add Bob #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgonet merged 7 commits into from
Feb 16, 2021
Merged

Add Bob #1360

jgonet merged 7 commits into from
Feb 16, 2021

Conversation

@jgonet
Copy link
Member

@jgonet jgonet commented Feb 12, 2021 •
edited
Loading

Description

Fixes #1344

Add Bob so RNGH can be used for various platforms.

Changes

  • Moved index.ts to src/index.ts
  • Adjusted babel config in Example app
  • Adjusted imports for Drawer & Swipeable

@jgonet jgonet requested a review from WoLewicki February 12, 2021 21:49
@jgonet jgonet self-assigned this Feb 12, 2021
WoLewicki
WoLewicki approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Make sure the lib directories in DrawerLayout and Swipeable are properly matched.

@jgonet
Copy link
Member Author

jgonet commented Feb 15, 2021 •
edited
Loading

\cc @satya164

We use jestSetup.js to provide mocks. I didn't find much information about it in the jest docs, will it work with Bob?

Bob ignores __mocks__ (at least with default config) directories and it looks like generated directories won't be mocked automatically.

Also, I'm pretty sure Bob was here before but was lost in the sands of time.

satya164
satya164 reviewed Feb 15, 2021
View reviewed changes
@jgonet jgonet merged commit 6437398 into master Feb 16, 2021
@jgonet jgonet deleted the @kuba/add-bob branch February 16, 2021 12:16
braincore pushed a commit to braincore/react-native-gesture-handler that referenced this pull request Mar 4, 2021
@jgonet @braincore
Add Bob (software-mansion#1360)
708d3be
This was referenced Mar 13, 2021
Closed
Closed
@jgonet jgonet mentioned this pull request May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WoLewicki WoLewicki WoLewicki approved these changes

+1 more reviewer

@satya164 satya164 satya164 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jgonet jgonet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

} as const; react-native-gesture-handler\src\State.ts: Unexpected token (10:5)

4 participants

@jgonet @satya164 @WoLewicki