Skip to content

Conversation

@jgonet
Copy link
Member

@jgonet jgonet commented Jan 26, 2022

Description

Removed some unused dev packages.

Test plan

Ran example app on iOS.

- Removed unused eslint configs
- Removed flow support
- Replaced jest-react-native with react-native preset
@jgonet jgonet requested a review from j-piasecki January 26, 2022 15:24
@jgonet jgonet changed the title Remove unused devPackages Remove unused devDependencies Jan 26, 2022
It's used in eslintrc config
Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check failing suggests that some of them weren't unused. Keeping eslint-import-resolver-babel-module and adding eslint-plugin-jest seems to be enough to make it work.

@jgonet jgonet merged commit dfd4c5a into main Jan 27, 2022
@jgonet jgonet deleted the jgonet/cleanup-packages branch January 27, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants