Fix ripple animation on touchables in some cases #1877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In cases where
TouchableOpacityandTouchableNativeFeedbackwere used together, butTouchableOpacitywas placed first, the color of ripple animation would also be set totransparentforTouchableNativeFeedback. This PR changes the behavior of GestureHandlerButton so that it will set the color of ripple animation toandroid.R.attr.colorControlHighlightwhen no color is set by the user.Test plan
Tested on this code: