Skip to content

Use subscription.remove() instead of EventEmitter.removeSubscription() in EventReceiver #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
j-piasecki merged 1 commit into from
Feb 22, 2022
Merged

Use subscription.remove() instead of EventEmitter.removeSubscription() in EventReceiver #1888

j-piasecki merged 1 commit into from
Feb 22, 2022

Conversation

@j-piasecki
Copy link
Member

@j-piasecki j-piasecki commented Feb 22, 2022

Description

Change how device event subscriptions are removed to use .remove() on subscription itself instead of DeviceEventEmitter.removeSubscription(...).

@j-piasecki j-piasecki merged commit 4e21787 into main Feb 22, 2022
@j-piasecki j-piasecki deleted the @jpiasecki/remove-subscription branch February 22, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-piasecki @tomekzaw