Add manual gestures example & Fix Draggable example #1926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Mar 14, 2022
Member
j-piasecki
left a comment
j-piasecki
left a comment
There was a problem hiding this comment.
Hi! Thank you for taking the time to do this ❤️ .
Co-authored-by: Jakub Piasecki <[email protected]>
Contributor
Author
|
@j-piasecki Hi, Thank you for your review! 💗 |
j-piasecki
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, maintainers, thank you so much for doing a great project for React Native, I like this project very much!
I'm happy to do somethings for this project!
This PR is innocuous for this lib, just fix bug and add example.
Add manual gestures example, I looked at your documentation, but found this Manual gestures without an example, So I added.
Fix Draggable example, had bug, onLongPress callback method should run on JSThread that can execute the
setState.Test plan
This is the error thrown, After I fixed it: