Effectively remove RNGestureHandlerEnabledRootView
#1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
changed the title
RNGestureHandlerEnabledRootView when it's not usedRNGestureHandlerEnabledRootView
|
@j-piasecki Hi, very happy to see that you found a way to solve this problem. When can this be merged? |
Member
Author
|
@LFMAKER It should be merged after @kmagiera gives it a green light, but hopefully soon. |
kmagiera
approved these changes
Mar 28, 2022
3 tasks
2 tasks
This was referenced Mar 31, 2022
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tryInitializeHandlerForReactRootViewwas causing crashes, especially with combination with CodePush.RNGestureHandlerEnabledRootViewwas deprecated in version 2.0.0 in favor ofGestureHandlerRootViewcomponent and this PR removes implementation ofRNGestureHandlerEnabledRootViewand code responsible for interactions with it.Adds a new page in docs explaining how to migrate to
GestureHandlerRootView.Potentially fixes #1675.
Test plan
Checked on the Example app