Skip to content

Conversation

@alantoa
Copy link
Contributor

@alantoa alantoa commented Mar 19, 2022

Description

Hi, maintainers, I'm looking at a lot of interesting examples, I found warnings and errors in many places.
This PR is mainly to fix some problems in Example.

  • Update @react-navigation version to remove warnings.
  • Fixed example/bottom_sheet some bugs

Error & Warining logs

WX20220320-011941@2x

screenshot-20220320-011809

Test plan

This is a safe change, It's been tested!

Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for fixing it ❤️. I have a question though

@alantoa
Copy link
Contributor Author

alantoa commented Mar 24, 2022

Hi, @j-piasecki, thank you for review.
I fixed it, check please!

Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@j-piasecki j-piasecki merged commit 082b9ee into software-mansion:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants