🔧🇫🇮 Fix TypeScript typing issues with setTimeout by removing NodeJS types
#1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikra
changed the title
setTimeout by removing NodeJS typessetTimeout by removing NodeJS types
j-piasecki
reviewed
Mar 28, 2022
Member
j-piasecki
left a comment
j-piasecki
left a comment
There was a problem hiding this comment.
Hi! Thanks for taking the time to look into this, however In my opinion a simple ts-ignore with an explanation here instead of adding a new file would suffice in this case. Especially because this way the explanation would be in the same place as the usage.
Contributor
Author
|
@j-piasecki Done 🇫🇮 🥑 |
hamidhadi
reviewed
Mar 28, 2022
src/utils.ts
Outdated
| } | ||
|
|
||
| export function isJestEnv(): boolean { | ||
| // @ts-ignore Do not use `@types/node` because it will break setTimeout function types in React Native projects |
There was a problem hiding this comment.
Hey @henrikra,
Thanks for doing this! 🙌
As it's not only breaking the setTimeout but also other stuff like setInterval, I would rewrite this comment in this way:
Using `@types/node` will prioritise node types over RN types which can break the types in React Native projects.
j-piasecki
approved these changes
Mar 28, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR https://github.com/software-mansion/react-native-gesture-handler/pull/1844/files#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0 added
nodeto thetypesarray oftsconfig. This causes all of the React Native projects withgesture-handleras dependency to get Node typings to their project and node has conflicting types with Dom onsetTimeout.This PR gets rid of the
nodetyping and adds a new file which adds missing types to gesture handler project.Long story short:
🔴 We were requiring the whole NodeJS types just because we wanted to use
process.env.JEST_WORKER_ID✅ Fixed by not requiring NodeJS types and just typed out the
process.env.JEST_WORKER_IDFixes #1958
Test plan
Run
yarn ts-checkand see that not TSC errors are produced.