Skip to content

Add missing props to GestureButton type #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-piasecki merged 1 commit into from
Apr 4, 2022
Merged

Add missing props to GestureButton type #1981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/components/GestureButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,27 @@ export interface RawButtonProps extends NativeViewGestureHandlerProps {
* Defines color of native ripple animation used since API level 21.
*/
rippleColor?: any; // it was present in BaseButtonProps before but is used here in code

/**
* Android only.
*
* Defines radius of native ripple animation used since API level 21.
*/
rippleRadius?: number | null;

/**
* Android only.
*
* Set this to true if you want the ripple animation to render outside the view bounds.
*/
borderless?: boolean;

/**
* Android only.
*
* Defines whether the ripple animation should be drawn on the foreground of the view.
*/
foreground?: boolean;
}

export interface BaseButtonProps extends RawButtonProps {
Expand Down Expand Up @@ -69,13 +90,6 @@ export interface RectButtonProps extends BaseButtonProps {
}

export interface BorderlessButtonProps extends BaseButtonProps {
/**
* Android only.
*
* Set this to false if you want the ripple animation to render only within view bounds.
*/
borderless?: boolean;

/**
* iOS only.
*
Expand Down