Skip to content

Conversation

@j-piasecki
Copy link
Member

Description

This PR:

  • changes StateChangeHook to NativeViewGestureHandlerHook and adds more methods to it
  • adds default hook that doesn't change the behavior of the gesture
  • adds onPrepare method to base GestureHandler allowing handlers to perform specific actions
  • adds logic for using correct hook in onPrepare method
  • adds super call to shouldRecognizeSimultaneously in NativeViewGestureHandler - without this simultaneousHandlers prop is effectively ignored

Test plan

Tested on the Example app.

@j-piasecki j-piasecki merged commit 7de4c8f into main May 12, 2022
@j-piasecki j-piasecki deleted the @jpiasecki/native-view-gesture-handler-extensions branch May 12, 2022 08:55
j-piasecki added a commit that referenced this pull request Jun 15, 2022
… `TextInput` (#2017)

This PR makes use of extension mechanism from #2016 to make `TextInput` behave more similarly to iOS when wrapped with other gesture handlers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants