Skip to content

Ensure compatability with Jest 28 #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
piaskowyk merged 3 commits into from
Jul 1, 2022
Merged

Ensure compatability with Jest 28 #3217

piaskowyk merged 3 commits into from
Jul 1, 2022

Conversation

@matt-oakes
Copy link

@matt-oakes matt-oakes commented May 6, 2022

Description

Fixes for Jest 28 compatability (Issue #3215)

Changes

  • Change the import for expect to maintain compatability with Jest 28.
  • Updated the documentation to ensure the enviornment is set up before running the script.

Checklist

  • Included code example that can be used to test this change
  • Updated TS types
  • Added TS types tests
  • Added unit / integration tests
  • Updated documentation
  • Ensured that CI passes

@matt-oakes matt-oakes mentioned this pull request May 6, 2022
Closed
@piaskowyk
Copy link
Member

piaskowyk commented May 12, 2022

Hey 👋 Thanks for the PR!
Do these changes compatible with Jest versions older than 28?

@mayconline
Copy link

mayconline commented May 26, 2022

Hey wave Thanks for the PR! Do these changes compatible with Jest versions older than 28?

I believe no, this solution is a braking change for v28,
link helper upgrade: https://jestjs.io/pt-BR/docs/upgrading-to-jest28

@simoneb
Copy link

simoneb commented May 30, 2022

Any plans to release this?

@wmiklasewicz
Copy link

wmiklasewicz commented Jun 10, 2022

Hey guys, any update on that one?

@piaskowyk piaskowyk self-assigned this Jul 1, 2022
@piaskowyk piaskowyk changed the base branch from main to @piaskowyk/jest-28-support July 1, 2022 10:43
@piaskowyk
Copy link
Member

piaskowyk commented Jul 1, 2022

Thanks for your PR! I will add to it backward compatibility.

@piaskowyk piaskowyk merged commit 234c75b into software-mansion:@piaskowyk/jest-28-support Jul 1, 2022
@piaskowyk piaskowyk mentioned this pull request Jul 1, 2022
Merged
piaskowyk added a commit that referenced this pull request Jul 1, 2022
@piaskowyk
Support for Jest 28 (#3347)
930b2d1 
## Description

Add support for Jest 28 with backward compatibility.

Based on: #3217
piaskowyk added a commit that referenced this pull request Jul 1, 2022
@piaskowyk
Support for Jest 28 (#3347)
da2a8e1 
## Description

Add support for Jest 28 with backward compatibility.

Based on: #3217
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
@piaskowyk @fluiddot
Support for Jest 28 (software-mansion#3347)
f51b4f7 
## Description

Add support for Jest 28 with backward compatibility.

Based on: software-mansion#3217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@piaskowyk piaskowyk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matt-oakes @piaskowyk @mayconline @simoneb @wmiklasewicz