Skip to content

Conversation

@buffalojoec
Copy link
Contributor

This PR makes a temporary fix for CI to enable using the 1.17.x test validator, where the following change has been implemented: solana-labs/solana#33531.

When 1.17 goes live on mainnet-beta, we can revert the changes to the test scripts, such as scripts/setup-test-validator.sh.

An issue has been created to remind us of this revert.

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mergify mergify bot added the community label Oct 10, 2023
@mergify mergify bot requested a review from a team October 10, 2023 12:48
@buffalojoec buffalojoec force-pushed the 10-10-refactor_experimental_update_test_validator_with_new_vote_account_state branch from 59049b9 to 31d0420 Compare October 10, 2023 12:51
@buffalojoec
Copy link
Contributor Author

Note: With 1.17 the following error has changed from the getStakeActivation RPC method:

Original:

failed to get Stake Activation <xxxx>: Invalid param: epoch <epoch> has not yet started

New error:

failed to get Stake Activation <xxxx>: Invalid param: epoch <epoch>. Only the current epoch (0) is supported

@buffalojoec
Copy link
Contributor Author

Note: With 1.17 the following error has changed from the getStakeActivation RPC method:

Original:

failed to get Stake Activation <xxxx>: Invalid param: epoch <epoch> has not yet started

New error:

failed to get Stake Activation <xxxx>: Invalid param: epoch <epoch>. Only the current epoch (0) is supported

disregard, this should not affect CI since it only happens when the TEST_LIVE variable is set

@buffalojoec buffalojoec force-pushed the 10-10-refactor_experimental_update_test_validator_with_new_vote_account_state branch 2 times, most recently from f3cf69c to 18e98e5 Compare October 10, 2023 13:45
@buffalojoec buffalojoec force-pushed the 10-10-refactor_experimental_update_test_validator_with_new_vote_account_state branch from 18e98e5 to af224bc Compare October 10, 2023 13:51
@buffalojoec buffalojoec merged commit eb5fd16 into master Oct 10, 2023
@buffalojoec buffalojoec deleted the 10-10-refactor_experimental_update_test_validator_with_new_vote_account_state branch October 10, 2023 13:56
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.87.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants