fix: downshift preflightCommitment to processed when bypassing preflight checks
#2415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7f406cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
commented
Apr 2, 2024
steveluscher
force-pushed
the
04-02-fix_downshift_preflightcommitment_to_processed_when_bypassing_preflight_checks
branch
from
c00f0c9 to
6199e68
Compare
steveluscher
force-pushed
the
04-02-fix_downshift_preflightcommitment_to_processed_when_bypassing_preflight_checks
branch
from
6199e68 to
7f406cc
Compare
steveluscher
deleted the
04-02-fix_downshift_preflightcommitment_to_processed_when_bypassing_preflight_checks
branch
Contributor
|
🎉 This PR is included in version 1.91.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There's a bug in the
sendTransactionRPC method where, when bypassing preflight, we nevertheless materially use the value ofpreflightCommitmentto determine how to behave when sending the transaction.If you supply nothing – as you might think appropriate when skipping preflight – then the default of
finalizedwill be used. Far from irrelevant, such a value can actually affect the retry behaviour of the send-transaction-service (STS). Read anza-xyz/agave#483 for more detail.In this PR, we try to get ahead of anza-xyz/agave#483 by setting this value to
processedin the client. Until the server PR is deployed widely, this should cover those who choose to upgradeAddresses anza-xyz/agave#479
Test plan