This repository was archived by the owner on Jan 22, 2025. It is now read-only.
sort storages by slot before scan #17411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
flatten3
branch
2 times, most recently
from
700cd92 to
ca216bf
Compare
jeffwashington
commented
May 22, 2021
brooksprumo
reviewed
May 23, 2021
Contributor
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
I'm assuming the sorting helps speed up the scan? Also assuming the speed up to the scan is greater than the time to sort, yes?
jeffwashington
commented
May 26, 2021
brooksprumo
reviewed
May 26, 2021
Contributor
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
My comments are mostly questions :)
jeffwashington
force-pushed
the
flatten3
branch
14 times, most recently
from
282c98a to
95da609
Compare
Codecov Report
@@ Coverage Diff @@
## master #17411 +/- ##
========================================
Coverage 82.7% 82.8%
========================================
Files 428 429 +1
Lines 119964 120063 +99
========================================
+ Hits 99325 99435 +110
+ Misses 20639 20628 -11 |
brooksprumo
reviewed
Jun 1, 2021
Contributor
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
Looks good! Just the two questions/comments.
brooksprumo
previously approved these changes
Jun 1, 2021
jeffwashington
added
the
automerge
brooksprumo
approved these changes
Jun 1, 2021
Contributor
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
Re-approving since mergify removed it.
jeffwashington
removed
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2021
* sort storages by slot before scan * fix return value (cherry picked from commit ef5169f) # Conflicts: # runtime/src/accounts_db.rs
jeffwashington
added a commit
that referenced
this pull request
Jun 3, 2021
* sort storages by slot before scan * fix return value (cherry picked from commit ef5169f) # Conflicts: # runtime/src/accounts_db.rs
mergify bot
added a commit
that referenced
this pull request
Jun 4, 2021
* sort storages by slot before scan * fix return value (cherry picked from commit ef5169f) # Conflicts: # runtime/src/accounts_db.rs Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
2 different use cases have emerged where it is useful to have storages sorted by slot.
Summary of Changes
Sort storages by slot.
Fixes #