This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Rework #17486 #17566
Merged
Rework #17486 #17566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
force-pushed
the
restrict-filepath
branch
from
6778463 to
fa22a17
Compare
jackcmay
reviewed
May 28, 2021
Contributor
|
There was a suggestion that we just force cli users to setup a default keypair because they will eventually need it anyway and might as well have them address it from the start. |
t-nelson
force-pushed
the
restrict-filepath
branch
2 times, most recently
from
6c4d80a to
b457f6f
Compare
Contributor
Author
|
Ok, I re-reworked this so that it defers the |
t-nelson
force-pushed
the
restrict-filepath
branch
from
b457f6f to
f7b300d
Compare
jackcmay
previously approved these changes
May 28, 2021
CriesofCarrots
previously approved these changes
May 28, 2021
t-nelson
added
the
automerge
mergify
bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
mergify
bot
dismissed stale reviews from jackcmay and CriesofCarrots
Pull request has been modified.
This was referenced May 29, 2021
mergify bot
added a commit
that referenced
this pull request
May 31, 2021
* Revert "Improve missing default signer error messaging (#17486)" This reverts commit 6d40d0d. (cherry picked from commit ca8c1c6) * Improve missing default filepath signer error messaging (cherry picked from commit 06a926f) * CI: temporarily skip spl downstream build (cherry picked from commit d01b4f8) Co-authored-by: Trent Nelson <[email protected]>
mergify bot
added a commit
that referenced
this pull request
May 31, 2021
* Revert "Improve missing default signer error messaging (#17486)" This reverts commit 6d40d0d. (cherry picked from commit ca8c1c6) * Improve missing default filepath signer error messaging (cherry picked from commit 06a926f) * CI: temporarily skip spl downstream build (cherry picked from commit d01b4f8) Co-authored-by: Trent Nelson <[email protected]>
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#17486 introduced several issues
solana validatorsspl-tokenCLISummary of Changes
SignerSourcesReview hints: