This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fail simulation if transaction contains duplicate accounts #18304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
simulation-dupes
branch
from
6beca20 to
76a8779
Compare
Codecov Report
@@ Coverage Diff @@
## master #18304 +/- ##
=========================================
- Coverage 82.3% 82.3% -0.1%
=========================================
Files 433 433
Lines 121157 121168 +11
=========================================
- Hits 99813 99785 -28
- Misses 21344 21383 +39 |
Contributor
Author
|
low risk change, merging! |
mergify bot
pushed a commit
that referenced
this pull request
Jun 30, 2021
(cherry picked from commit b08f8bd)
mergify bot
added a commit
that referenced
this pull request
Jun 30, 2021
…18334) (cherry picked from commit b08f8bd) Co-authored-by: Justin Starry <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Simulation allows processing invalid transactions with duplicate accounts.