This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Update verify policy #18459
Merged
Update verify policy #18459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
approved these changes
Jul 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #18459 +/- ##
=========================================
- Coverage 82.5% 82.5% -0.1%
=========================================
Files 436 436
Lines 121850 121851 +1
=========================================
- Hits 100605 100597 -8
- Misses 21245 21254 +9 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2021
(cherry picked from commit 44289e6) # Conflicts: # runtime/src/message_processor.rs
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2021
(cherry picked from commit 44289e6)
mergify bot
added a commit
that referenced
this pull request
Jul 7, 2021
* Update verify policy (#18459) (cherry picked from commit 44289e6) # Conflicts: # runtime/src/message_processor.rs * resolve conflicts Co-authored-by: Jack May <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jul 7, 2021
* Update verify policy (#18459) (cherry picked from commit 44289e6) * resolve conflicts Co-authored-by: Jack May <[email protected]>
t-nelson
reviewed
Jul 7, 2021
| if !is_writable // line coverage used to get branch coverage | ||
| || pre.executable() | ||
| || program_id != pre.owner() | ||
| || program_id != post.owner() |
Contributor
There was a problem hiding this comment.
Ah, totally missed that in review. Needs gating because you could set executable to be true and get a successful transaction right?
Contributor
Author
There was a problem hiding this comment.
Yup, realized that as soon as I hit merge ;-).
This covers it: #18492
Contributor
There was a problem hiding this comment.
Ah, totally missed that in review. Needs gating because you could set executable to be true and get a successful transaction right?
These get easier to see the more cluster deaths you cause 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Update the owner and the executable at the same time
Summary of Changes
Catch in the verify stage
Fixes #