This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Cli: Remove dead solana airdrop parameters #18520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
added
v1.6
automerge
Codecov Report
@@ Coverage Diff @@
## master #18520 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 438 438
Lines 122823 122819 -4
=========================================
- Hits 101493 101469 -24
- Misses 21330 21350 +20 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit f39ffa6)
mergify bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit f39ffa6)
CriesofCarrots
added a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit f39ffa6)
CriesofCarrots
added a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit f39ffa6)
mergify bot
added a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit f39ffa6) Co-authored-by: Tyera Eulberg <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit f39ffa6) Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solana-cli was transitioned to RPC airdrops without changing the user interface. This means there are a couple existing parameters that don't do anything.
Summary of Changes
Take out the trash
Also improve airdrop about text slightly