This repository was archived by the owner on Jan 22, 2025. It is now read-only.
v1.7: backport new column families from master #18897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* backporting bank_hash and program_costs column families from master to 1.6 for rocksdb backward compatibility * missed a line to allow dead code * include code for purge
tao-stones
approved these changes
Jul 26, 2021
Contributor
tao-stones
left a comment
tao-stones
left a comment
There was a problem hiding this comment.
looks good to me, thanks @CriesofCarrots
CriesofCarrots
added
the
automerge
mergify
bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
CriesofCarrots
added
the
automerge
mergify
bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## v1.7 #18897 +/- ##
=========================================
- Coverage 82.3% 82.3% -0.1%
=========================================
Files 434 434
Lines 122714 122773 +59
=========================================
+ Hits 101035 101081 +46
- Misses 21679 21692 +13 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
New columns added to master creates ledgers that are incompatible with v1.7, as described in issue #18729.
Summary of Changes
Backport
bank_hashandprogram_costscolumn families from master to 1.7 for backward compatibility.Also excludes the stubbed ProgramCosts column from compaction, an oversight that footgunned v1.6 (cc #18840 )
Closes #18724