Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@jstarry
Copy link
Contributor

@jstarry jstarry commented Aug 17, 2021

Problem

Explorer home page fetches circulating supply stats on load but the perf is really bad because the full list of non-circulating accounts is returned.

Summary of Changes

  • Add excludeNonCirculatingAccountsList param to get_supply RPC method

Fixes #16146

@jstarry jstarry requested a review from CriesofCarrots August 17, 2021 20:39
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #19270 (b8ae5f9) into master (7a8807b) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #19270     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         455      455             
  Lines      130053   130073     +20     
=========================================
+ Hits       107737   107748     +11     
- Misses      22316    22325      +9     

@mergify mergify bot merged commit c053df1 into solana-labs:master Aug 17, 2021
@jstarry jstarry added the v1.7 label Aug 18, 2021
mergify bot pushed a commit that referenced this pull request Aug 18, 2021
(cherry picked from commit c053df1)

# Conflicts:
#	rpc/src/rpc.rs
@jstarry jstarry deleted the rpc/exclude-noncirc branch August 18, 2021 16:39
mergify bot added a commit that referenced this pull request Aug 18, 2021
…#19283)

* RPC: add option to exclude accounts from get_supply (#19270)

(cherry picked from commit c053df1)

# Conflicts:
#	rpc/src/rpc.rs

* resolve conflicts

Co-authored-by: Justin Starry <[email protected]>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RPC: make nonCirculatingAccounts optional on getSupply request

2 participants