This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Enable booting testnet validators without tower required #19298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
changed the title
CriesofCarrots
force-pushed
the
net-maybe-req-tower
branch
from
7ee4ac4 to
e8bc86b
Compare
Contributor
Author
|
Flaky |
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2021
(cherry picked from commit 7d135f1) # Conflicts: # net/net.sh
mergify bot
added a commit
that referenced
this pull request
Aug 19, 2021
…9298) (#19306) * Enable booting testnet validators without tower required (#19298) (cherry picked from commit 7d135f1) # Conflicts: # net/net.sh * Fix conflicts Co-authored-by: Tyera Eulberg <[email protected]> Co-authored-by: Tyera Eulberg <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When rebooting a testnet from a previous snapshot -- eg. in the case of cluster failure, or to test new code against many existing accounts -- the previous tower file may no longer be relevant. Currently the only way to allow the boot to proceed is to manually remove the
--require-towerarg from the multinode-demo scripts.Summary of Changes
Add a
--skip-require-toweroption to skip the--require-towerarg.This is foundational work to enable complete automation of rebooting testnet from previous snap.
Needs rebase on #19290